Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start work on supporting filtering while parsing #656

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Jun 25, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #656 into master will decrease coverage by 1.52%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   84.47%   82.95%   -1.53%     
==========================================
  Files           8        8              
  Lines        1701     1748      +47     
==========================================
+ Hits         1437     1450      +13     
- Misses        264      298      +34     
Impacted Files Coverage Δ
src/utils.jl 84.50% <ø> (ø)
src/file.jl 90.56% <63.91%> (-5.75%) ⬇️
src/rows.jl 93.22% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74c2fc...bce612f. Read the comment docs.

@quinnj quinnj changed the base branch from master to main March 26, 2021 18:56
@quinnj
Copy link
Member Author

quinnj commented May 12, 2021

@NHDaly, sorry for the slightly random ping, but I'm actually diving back in to the code here and want to make a push. would you mind taking a look here if you have a moment? Happy to jump on a quick call too if that'd be easier to do a quick review of what's going on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant